Skip to content

EIP4844: various fixes#3019

Merged
djrtwo merged 3 commits intoethereum:devfrom
terencechain:fix-eip4844
Sep 30, 2022
Merged

EIP4844: various fixes#3019
djrtwo merged 3 commits intoethereum:devfrom
terencechain:fix-eip4844

Conversation

@terencechain
Copy link
Contributor

  • Add unit epoch to MIN_EPOCHS_FOR_BLOBS_SIDECARS_REQUESTS
  • The current backfill blob validation is incorrect. It looks like it was copy-pasted from backfill block validation. I removed it. It might be worth considering what backfill validation we want for the blob. To validate the signature, we need to change BlobsSidecarsByRange to SignedBlobsSidecarsByRange. It may be worth checking that blobs are canonical by cross-referencing with the local fork choice view
  • Validator broadcasts signed_beacon_block, not beacon_block

Co-authored-by: Lion - dapplion <35266934+dapplion@users.noreply.github.com>
@hwwhww hwwhww added the deneb label Sep 30, 2022
@djrtwo djrtwo merged commit 6b9e65f into ethereum:dev Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants